Create temp directories for all tests in kprobes #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIXES: #238 Signed-off-by: Anastasios Papagiannis <[email protected]>
willfindlay
approved these changes
Jul 21, 2022
| kpChecker := ec.NewProcessKprobeChecker(). | ||
| WithFunctionName(sm.Full("__x64_sys_openat")). | ||
| WithArgs(ec.NewKprobeArgumentListMatcher(). | ||
| WithOperator(lc.Ordered). | ||
| WithValues( | ||
| ec.NewKprobeArgumentChecker().WithIntArg(-100), | ||
| ec.NewKprobeArgumentChecker().WithStringArg(sm.Full(mountPath+"/testfile")), | ||
| ec.NewKprobeArgumentChecker().WithStringArg(sm.Full(filepath.Join(dir, "testfile"))), |
There was a problem hiding this comment.
This will fail if someone passes a non-absolute path here. I would suggested using a suffix matcher here, possibly stripping the leading periods if they exist.
There was a problem hiding this comment.
Good catch! So this will fail in the case where we use getOpenatChecker() in a testcase where we don't use the correct path in __x64_sys_openat. I propose to just be aware of that (i.e. add a comment/issue) when we add new tests.
I believe that we need more work to make that generic enough to handle all cases in __x64_sys_openat. WDYT?
There was a problem hiding this comment.
Documenting the limitation is a fine approach IMO.
kkourt
approved these changes
Jul 27, 2022
|
@tpapagian follow up with some documentation per review where appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that tests that fail to create a new directory (i.e. already exists) just skipped.
FIXES: #238
Signed-off-by: Anastasios Papagiannis [email protected]