Implement pod label filter #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/add-pod-label
branch
from
1005018 to
9382604
Compare
sharlns
reviewed
Jul 21, 2022
sharlns
approved these changes
Jul 21, 2022
michi-covalent
force-pushed
the
pr/michi/add-pod-label
branch
5 times, most recently
from
457ba35 to
2051125
Compare
kkourt
reviewed
Jul 25, 2022
This commit adds a "pod_labels" field to the Pod message. The high-level goal is to implement an event filter that matches on pod labels. The Pod message currently has labels field that contains Cilium identity labels, but it's not sufficient for pod label filter since it's a subset of pod labels. Another option would be to use the existing labels field and populate it with pod labels instead of Cilium identity labels. I opted to add a new field to preserve backward compatibility. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/add-pod-label
branch
from
2051125 to
2f2c5ca
Compare
Add an event filter that matches on process.pod_labels field using Kubernetes label selector syntax, similar to how Hubble implements its label filter on flows. Ref: https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#label-selectors Ref: https://github.com/cilium/cilium/blob/master/pkg/hubble/filters/labels.go Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/add-pod-label
branch
from
2f2c5ca to
468f882
Compare
kkourt
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits: