Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: exclude api tags from version #2538

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Jun 11, 2024

cf0a49d introduced a tag for the api module. This, however, breaks the release process because the tarball image generation uses the api version and fails. Exclude the api tags from the version.

cf0a49d introduced a tag for the api
module. This, however, breaks the release process because the tarball
image generation uses the api version and fails. Exclude the api tags
from the version.

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt requested a review from a team as a code owner June 11, 2024 14:50
@kkourt kkourt requested a review from jrfastab June 11, 2024 14:50
@kkourt kkourt added needs-backport/1.1 This PR needs backporting to 1.1 release-note/misc This PR makes changes that have no direct user impact. labels Jun 11, 2024
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fascinating

@kkourt kkourt merged commit 8dd832b into main Jun 11, 2024
38 of 40 checks passed
@kkourt kkourt deleted the pr/kkourt/makefile-fix branch June 11, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport/1.1 This PR needs backporting to 1.1 release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants