Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: fix Go postUpgradeTasks for stable branches #2514

Merged
merged 1 commit into from
Jun 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"^make vendor$",
"^make -C install/kubernetes$",
"^go mod vendor$",
"^install-tool golang \\$\\(grep -oP '\\^go \\\\K\\.\\+' go\\.mod\\)$",
"^install-tool golang \\$\\(grep -oP '\\^toolchain go\\\\K\\.\\+' go\\.mod\\)$"
],
// repository configuration
Expand Down Expand Up @@ -212,11 +213,16 @@
}
},
{
// main branch is using the new toolchain directive
"groupName": "Go",
"matchPackageNames": [
"go",
"docker.io/library/golang"
],
"matchBaseBranches": [
"v1.0",
"v1.1",
],
// postUpgradeTasks is only for when the Go module directives are bumped
"postUpgradeTasks": {
// We need to trigger a golang install manually here because in some
Expand All @@ -227,6 +233,27 @@
"executionMode": "branch"
},
},
{
// stable branches are using the go directive
"groupName": "Go",
"matchPackageNames": [
"go",
"docker.io/library/golang"
],
"matchBaseBranches": [
"v1.0",
"v1.1",
],
// postUpgradeTasks is only for when the Go module directives are bumped
"postUpgradeTasks": {
// We need to trigger a golang install manually here because in some
// cases it might not be preinstalled, see:
// https://github.com/renovatebot/renovate/discussions/23485
"commands": ["install-tool golang $(grep -oP '^go \\K.+' go.mod)", "make vendor"],
"fileFilters": ["**/**"],
"executionMode": "branch"
},
},
{
// Group golangci-lint updates to overrule grouping of version updates in
// the GHA files. Without this, golangci-lint updates are not in sync for
Expand Down
Loading