renovate: update Go version properly for v1.1 #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
area/ci
kkourt
approved these changes
Jun 5, 2024
kkourt
reviewed
Jun 5, 2024
.github/renovate.json5
Outdated
| ] | ||
| }, | ||
| { | ||
| // update go version <1.22 for stable branches |
There was a problem hiding this comment.
I'm reading this as <1.22 so <=1.21.x, but I guess the intention is to update to latest 1.22.x, correct?
There was a problem hiding this comment.
correct, let's write it in plain English in a correct way https://github.com/cilium/tetragon/compare/8dbabfe0a79fddb36bca8c674051bf8f41b0e71d..a4c4e06de11303b05bf4b14f6e4f9772049c40b7
Stable branch v1.1 was put in the rule to update <1.21 while it was already using 1.22. This fix should allow proper patch updates on v1.1 for the go version. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/renovate-go-v1.1
branch
from
8dbabfe to
a4c4e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable branch v1.1 was put in the rule to update <1.21 while it was already using 1.22. This fix should allow proper patch updates on v1.1 for the go version.