-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renovate: switch to get Go version from toolchain directive #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now use the toolchain as the version we should use because of #2425, renovate need to pick up the toolchain version for its Go install fix. Signed-off-by: Mahe Tardy <[email protected]>
michi-covalent
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so many slashes it must be correct
mtardy
added a commit
that referenced
this pull request
Jun 5, 2024
We recently switched to use the toolchain directive on the main which broke Go updates postUpgradeTasks on stable branches (see #2494 or commit bee5a74). Signed-off-by: Mahe Tardy <[email protected]>
mtardy
added a commit
that referenced
this pull request
Jun 5, 2024
We recently switched to using the toolchain directive on the main which broke Go updates postUpgradeTasks on stable branches (see #2494 or commit bee5a74). Signed-off-by: Mahe Tardy <[email protected]>
mtardy
added a commit
that referenced
this pull request
Jun 5, 2024
We recently switched to using the toolchain directive on the main which broke Go updates postUpgradeTasks on stable branches (see #2494 or commit bee5a74). Signed-off-by: Mahe Tardy <[email protected]>
mtardy
added a commit
that referenced
this pull request
Jun 5, 2024
We recently switched to using the toolchain directive on the main which broke Go updates postUpgradeTasks on stable branches (see #2494 or commit bee5a74). Signed-off-by: Mahe Tardy <[email protected]>
mtardy
added a commit
that referenced
this pull request
Jun 5, 2024
We recently switched to using the toolchain directive on the main which broke Go updates postUpgradeTasks on stable branches (see #2494 or commit bee5a74). Signed-off-by: Mahe Tardy <[email protected]>
mtardy
added a commit
that referenced
this pull request
Jun 6, 2024
We recently switched to using the toolchain directive on the main which broke Go updates postUpgradeTasks on stable branches (see #2494 or commit bee5a74). Signed-off-by: Mahe Tardy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now use the toolchain as the version we should use because of #2425, renovate need to pick up the toolchain version for its Go install fix.
Trying to fix the issue in #2490.