Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: switch to get Go version from toolchain directive #2494

Merged
merged 1 commit into from
May 31, 2024

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented May 31, 2024

Since we now use the toolchain as the version we should use because of #2425, renovate need to pick up the toolchain version for its Go install fix.

Trying to fix the issue in #2490.

Since we now use the toolchain as the version we should use because of #2425,
renovate need to pick up the toolchain version for its Go install fix.

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy mtardy added the release-note/ci This PR makes changes to the CI. label May 31, 2024
@mtardy mtardy requested a review from a team as a code owner May 31, 2024 10:52
@mtardy mtardy requested a review from jrfastab May 31, 2024 10:52
zaru0099

This comment was marked as spam.

Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many slashes it must be correct

@mtardy mtardy merged commit bee5a74 into main May 31, 2024
40 checks passed
@mtardy mtardy deleted the pr/mtardy/renovate-install-go-version branch May 31, 2024 15:39
mtardy added a commit that referenced this pull request Jun 5, 2024
We recently switched to use the toolchain directive on the main which
broke Go updates postUpgradeTasks on stable branches (see #2494 or
commit bee5a74).

Signed-off-by: Mahe Tardy <[email protected]>
mtardy added a commit that referenced this pull request Jun 5, 2024
We recently switched to using the toolchain directive on the main which
broke Go updates postUpgradeTasks on stable branches (see #2494 or
commit bee5a74).

Signed-off-by: Mahe Tardy <[email protected]>
mtardy added a commit that referenced this pull request Jun 5, 2024
We recently switched to using the toolchain directive on the main which
broke Go updates postUpgradeTasks on stable branches (see #2494 or
commit bee5a74).

Signed-off-by: Mahe Tardy <[email protected]>
mtardy added a commit that referenced this pull request Jun 5, 2024
We recently switched to using the toolchain directive on the main which
broke Go updates postUpgradeTasks on stable branches (see #2494 or
commit bee5a74).

Signed-off-by: Mahe Tardy <[email protected]>
mtardy added a commit that referenced this pull request Jun 5, 2024
We recently switched to using the toolchain directive on the main which
broke Go updates postUpgradeTasks on stable branches (see #2494 or
commit bee5a74).

Signed-off-by: Mahe Tardy <[email protected]>
mtardy added a commit that referenced this pull request Jun 6, 2024
We recently switched to using the toolchain directive on the main which
broke Go updates postUpgradeTasks on stable branches (see #2494 or
commit bee5a74).

Signed-off-by: Mahe Tardy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants