Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btf: print original error returned by ebpf btf.TypeByName() #2458

Merged
merged 1 commit into from
May 30, 2024

Conversation

tixxdz
Copy link
Member

@tixxdz tixxdz commented May 22, 2024

btf.TypeByName() could return ErrMultipleMatches if btf includes multiple matches.

@tixxdz tixxdz requested a review from a team as a code owner May 22, 2024 18:36
@tixxdz tixxdz requested a review from jrfastab May 22, 2024 18:36
@tixxdz tixxdz added the release-note/minor This PR introduces a minor user-visible change label May 22, 2024
@tixxdz tixxdz requested a review from olsajiri May 22, 2024 18:36
Copy link
Contributor

@olsajiri olsajiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, could you please put example of the new log message into the changelog? thanks

btf.TypeByName() could return ErrMultipleMatches if btf includes
multiple matches.

Possible returned errors:
- "syscall \"__x64_init_module\" (or \"__x64_init_module\") type name __x64_init_module: not found"
- "syscall \"__x64_sys_init_module\" (or \"__x64_sys_init_module\") type __x64_sys_init_module(*btf.Func): multiple matching types"

Signed-off-by: Djalal Harouni <[email protected]>
@tixxdz tixxdz force-pushed the pr/tixxdz/2024-05-print-btf-symbol-name-error branch from 76c8e2a to ca44e19 Compare May 30, 2024 17:03
@tixxdz
Copy link
Member Author

tixxdz commented May 30, 2024

looks good, could you please put example of the new log message into the changelog? thanks

Thanks just did and pushed

Copy link

netlify bot commented May 30, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit ca44e19
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6658b17d5294f20008d46c0e
😎 Deploy Preview https://deploy-preview-2458--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tixxdz
Copy link
Member Author

tixxdz commented May 30, 2024

Merging as CI error is not related

@tixxdz tixxdz merged commit 30a2988 into main May 30, 2024
37 of 38 checks passed
@tixxdz tixxdz deleted the pr/tixxdz/2024-05-print-btf-symbol-name-error branch May 30, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants