-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: Add bpf program loader tests #244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
force-pushed
the
loader/tests
branch
6 times, most recently
from
July 25, 2022 08:09
1038261
to
d202145
Compare
olsajiri
force-pushed
the
loader/tests
branch
5 times, most recently
from
August 7, 2022 22:10
c1ff15f
to
d8a0602
Compare
olsajiri
force-pushed
the
loader/tests
branch
9 times, most recently
from
August 11, 2022 06:39
2f4969f
to
f9ef5e6
Compare
olsajiri
changed the title
tetragon: Add bpf program loader test
tetragon: Add bpf program loader tests
Aug 11, 2022
olsajiri
force-pushed
the
loader/tests
branch
4 times, most recently
from
August 11, 2022 13:21
4474e63
to
c18c0dd
Compare
olsajiri
force-pushed
the
loader/tests
branch
2 times, most recently
from
August 16, 2022 07:19
0a5c10a
to
8470a5d
Compare
kkourt
reviewed
Aug 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM! This is definitely needed.
I have some comments. None of them is a blocker, but might be worthwhile discussing them before merging.
Adding GetDefaultSensorsWithFile function to return sensors instead of observer object. It will be used in following tests. Signed-off-by: Jiri Olsa <[email protected]>
Adding LoadedCollection object to carry loaded programs/maps for program to be used later for TestLoad* tests to verify loaded programs and maps. Signed-off-by: Jiri Olsa <[email protected]>
Adding CheckSensorLoad function that takes array of programs and maps and checks they are loaded and share specified maps. Signed-off-by: Jiri Olsa <[email protected]>
Adding load test for initial sensors. Signed-off-by: Jiri Olsa <[email protected]>
Adding load test for generic kprobe sensors. Signed-off-by: Jiri Olsa <[email protected]>
Adding load test for generic tracepoint sensors. Signed-off-by: Jiri Olsa <[email protected]>
kkourt
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CheckSensorLoad function that takes array of programs
and maps and checks they are loaded and share specified maps.
Plus related changes to allow that.
Signed-off-by: Jiri Olsa [email protected]