-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update home page design #2374
Conversation
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that looks way better, especially since we switched logos!
I needed to remove a lot of the custom style because Docsy had a breaking change moving to Bootstrap 5 in v0.7.0
and most of the style written was broken https://github.com/google/docsy/releases/tag/v0.7.0. I hope this time, this is more resilient for future updates.
I have a few first comments, but I think this PR should be a draft given you have a lot of placeholders and links that don't work on the page, so I'll convert it to draft as of now, you can mark it ready once you want a full review.
I would say as long as the homepage doesn't affect how the rest of the documentation looks (typically the global font change isn't great) I'm super fine with it and happy that someone who can write serious design and CSS rewrote that.
7c85f18
to
086b82b
Compare
Just fyi, I updated Docsy and Hugo version, you might need to rebase on top of main (for that PR #2497). I checked, and nothing breaks on your homepage, you just need to merge some commits during the rebase but it should be trivial, just accept both changes all the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the commits into the first one maybe? thanks!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to merge but I did some checks and found some issues! Again if you fix this, feel free to squash your commits into one. Thanks a lot, overall it's night and day with the current homepage.
Signed-off-by: Raman Yasel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks fantastic! :)
This PR updates the style and design of the home page.