pkg:sensors: simplify GetRunningProcs() when we read running processes #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetRunningProcs() that reads process entries from procfs during startup takes two boolean arguments which we always set to true, then it passes these arguments down to how we send data to listeners and to write to the execve_map. Let's simplify this and remove these arguments as this makes reading code easier. Signed-off-by: Djalal Harouni <[email protected]>
michi-covalent
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetRunningProcs() that reads process entries from procfs during startup
takes two boolean arguments which we always set to true, then it passes
these arguments down to how we send data to listeners and to write to the
execve_map.
Let's simplify this and remove these arguments as this makes reading code
easier.
Signed-off-by: Djalal Harouni [email protected]