Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update demo app url #2311

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

yukinakanaka
Copy link
Contributor

Fixes: #2309

Current demo app url doesn't work in an ARM environment. It needs to be updated by following cilium repository's update: cilium/cilium#31373.

The new url worked in my ARM environment.

$ uname -a
Linux lima-tetragon-dev 5.15.0-101-generic #111-Ubuntu SMP Wed Mar 6 18:01:01 UTC 2024 aarch64 aarch64 aarch64 GNU/Linux

$ k create -f https://raw.githubusercontent.com/cilium/cilium/v1.15.3/examples/minikube/http-sw-app.yaml
service/deathstar created
deployment.apps/deathstar created
pod/tiefighter created
pod/xwing created

$ k get po
NAME                        READY   STATUS    RESTARTS   AGE
deathstar-b4b8ccfb5-kwz85   1/1     Running   0          12s
deathstar-b4b8ccfb5-z7pdj   1/1     Running   0          12s
tiefighter                  1/1     Running   0          12s
xwing                       1/1     Running   0          12s

@yukinakanaka yukinakanaka requested review from mtardy and a team as code owners April 8, 2024 07:05
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 6884c52
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6613974245365600086edcbf
😎 Deploy Preview https://deploy-preview-2311--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Apr 8, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the old version worked on my arm64 linux VM, but I thin it's just that I can run x86_64 thanks to the rosetta sharing of lima, so this is very specific to my setup and not generally aarch64 compatible. Thanks a lot, happy to update the deployment anyway!

@mtardy
Copy link
Member

mtardy commented Apr 8, 2024

Can you sign-off the commit?

Signed-off-by: yukinakanaka <[email protected]>
@yukinakanaka yukinakanaka force-pushed the pr/yukinakanaka/docs-demo-app branch from 6884c52 to c62c62e Compare April 8, 2024 11:07
@yukinakanaka
Copy link
Contributor Author

Thank you for your review! Oh, sorry I forgot sign-off. I amended it.

@mtardy
Copy link
Member

mtardy commented Apr 8, 2024

Thank you for your review! Oh, sorry I forgot sign-off. I amended it.

perfect thanks!

@mtardy mtardy merged commit 5c06f6d into cilium:main Apr 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Deploy demo application has issue on an ARM environment
2 participants