Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrantfile: bump Go version to 1.17 #228

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jul 12, 2022

Small fix, I was using the Vagrantfile, and recently the build of tetragon failed with Go 1.16, and make vendor was not working because the go mod tidy -compat flag was added in 1.17. I don't use snap but with a Go 1.17 version, it worked, I guess it's only mirroring what is used here https://github.com/cilium/tetragon/blob/main/.github/workflows/gotests.yml.

I guess you could directly install Go (I put 1.17.8 because you use it in the test workflow) with something like what I use in my Vagrantfiles and that looks like what you did with the rest:

GO_VERSION=1.17.8
curl -OL https://golang.org/dl/go$GO_VERSION.linux-amd64.tar.gz
rm -rf /usr/local/go && tar -C /usr/local -xzf go$GO_VERSION.linux-amd64.tar.gz
rm -f go$GO_VERSION.linux-amd64.tar.gz
echo "export PATH=$PATH:/usr/local/go/bin" >> ~/.bashrc

@mtardy mtardy requested a review from a team as a code owner July 12, 2022 17:08
@mtardy mtardy requested a review from kkourt July 12, 2022 17:08
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kkourt
Copy link
Contributor

kkourt commented Jul 12, 2022

The change is on the Vagrantfile, which is not tested. Merging without running tests.

@kkourt kkourt merged commit 38d3a61 into cilium:main Jul 12, 2022
@mtardy mtardy deleted the vagrant-bump-go-version branch July 12, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants