Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export HandleData from pkg/data/data.go #227

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Conversation

tpapagian
Copy link
Member

Can be used in other places as well and reduce code duplication.

Signed-off-by: Anastasios Papagiannis [email protected]

@tpapagian tpapagian requested a review from a team as a code owner July 12, 2022 06:18
@tpapagian tpapagian requested a review from kaworu July 12, 2022 06:18
@tpapagian
Copy link
Member Author

tpapagian commented Jul 12, 2022

Moving this to draft as I am considering some alternatives.

@tpapagian tpapagian marked this pull request as draft July 12, 2022 08:14
@tpapagian tpapagian marked this pull request as ready for review July 12, 2022 08:39
Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tpapagian

Can be used in other places as well and reduce code duplication.

Signed-off-by: Anastasios Papagiannis <[email protected]>
@tpapagian tpapagian force-pushed the pr/apapag/export_handledata branch from ad6175a to 90bd2bc Compare July 12, 2022 08:44
@kkourt kkourt merged commit 4fd4147 into main Jul 12, 2022
@kkourt kkourt deleted the pr/apapag/export_handledata branch July 12, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants