tetragon: Force libbpf link creation #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit [1] broke libbpf-install target, which fails if destination files exist: $ make libbpf-install mkdir -p ./lib docker cp 9fb245cca6f49264e1ce716b5db5d6864e734e07b0d1558110880b37f5d0aa85:/go/src/github.com/covalentio/hubble-fgs/src/libbpf.so.0.2.0 ./lib ln -s libbpf.so.0.2.0 ./lib/libbpf.so.0 ln: failed to create symbolic link './lib/libbpf.so.0': File exists make: *** [Makefile:176: libbpf-install] Error 1 I need to fix this to get clean update eventhough I'm removing the whole target in another libbpf remoal PR ;-) [1] 7c22ff1 create symlinks for libbpf.so for podman Signed-off-by: Jiri Olsa <[email protected]>
tpapagian
approved these changes
Jul 11, 2022
kkourt
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit [1] broke libbpf-install target, which fails
if destination files exist:
$ make libbpf-install
mkdir -p ./lib
docker cp 9fb245cca6f49264e1ce716b5db5d6864e734e07b0d1558110880b37f5d0aa85:/go/src/github.com/covalentio/hubble-fgs/src/libbpf.so.0.2.0 ./lib
ln -s libbpf.so.0.2.0 ./lib/libbpf.so.0
ln: failed to create symbolic link './lib/libbpf.so.0': File exists
make: *** [Makefile:176: libbpf-install] Error 1
I need to fix this to get clean update eventhough I'm removing
the whole target in another libbpf remoal PR ;-)
[1] 7c22ff1 create symlinks for libbpf.so for podman
Signed-off-by: Jiri Olsa [email protected]