Call go test only for directories that contain at least one test #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make test-compile iterates all directories with Go code and calls go test to build the executable. In many of the directories there are no tests which introduces delays in the make process. This commit calls go test only for directories that contain at least one test file (i.e. *_test.go). Before the fix: $ rm -rf go-tests/ && time make test-compile > /dev/null real 0m41.261s user 2m10.735s sys 0m24.337s $ ls -la go-tests/ | wc -l 36 After the fix: $ rm -rf go-tests/ && time make test-compile > /dev/null real 0m22.878s user 1m16.238s sys 0m10.950s $ ls -la go-tests/ | wc -l 36 Signed-off-by: Anastasios Papagiannis <[email protected]>
kkourt
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test-compileiterates all directories with Go code and calls go test to build the executable. In many of the directories there are no tests which introduces delays in the make process.This commit calls go test only for directories that contain at least one test file (i.e.
*_test.go).Before the fix:
After the fix:
Signed-off-by: Anastasios Papagiannis [email protected]