refactor: eliminate variables by BPF_CORE_READ_INTO #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forsworns
changed the title
kaworu
added
kind/enhancement
tpapagian
reviewed
Jul 7, 2022
bpf/lib/bpf_helpers.h
Outdated
| */ | ||
| static long (*bpf_probe_read)(void *dst, __u32 size, | ||
| const void *unsafe_ptr) = (void *)4; | ||
|
|
There was a problem hiding this comment.
because currently, probe_read is defined in https://github.com/cilium/tetragon/blob/HEAD/bpf/include/api.h#L206, so it can work without this definition.
However, BPF_CORE_READ_INTO in fact calls bpf_core_read, which is defined in
https://github.com/cilium/tetragon/blob/HEAD/bpf/libbpf/bpf_core_read.h#L117
by bpf_probe_read.
bpf_probe_read is not defined. So we have to supplement its definition, if we want to use BPF_CORE_READ_INTO.
kkourt
reviewed
Jul 11, 2022
kkourt
approved these changes
Aug 8, 2022
The BPF_CORE_READ_INTO can help reduce unnecessary variables and simplify the logic Signed-off-by: Peihao Yang <[email protected]>
Forsworns
force-pushed
the
bpf_core_into
branch
from
2f25478 to
5106199
Compare
|
Rebase since the definition of |
tpapagian
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BPF_CORE_READ_INTO can help reduce unnecessary variables and simplify the logic
Signed-off-by: Peihao Yang [email protected]