Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misalignment in execve_map #206

Merged
merged 2 commits into from
Jun 30, 2022
Merged

fix: misalignment in execve_map #206

merged 2 commits into from
Jun 30, 2022

Conversation

Forsworns
Copy link
Contributor

@Forsworns Forsworns commented Jun 29, 2022 •
edited by tpapagian
Loading

  1. add alignment checker for both key and value of execve_map

  2. append missing details on namespace and capacibilities for running processes during initialization

close: #205

Signed-off-by: Peihao Yang [email protected]

@Forsworns Forsworns requested a review from a team as a code owner June 29, 2022 09:52
@Forsworns Forsworns requested a review from jrfastab June 29, 2022 09:52
@Forsworns
Copy link
Contributor Author

BTW, why my PRs failed on sign-off checks...

@tpapagian
Copy link
Member

tpapagian commented Jun 29, 2022 •
edited
Loading

Regarding the CI failure maybe you should also add "Signed-off-by" on the PR message (except from the commits where you already did it).

This doesn't seem to fix this issue. I will check.

@tpapagian
Copy link
Member

In the message it says that it expects: Forsworns [email protected]. Can you update to use that? is that a valid name/email?

@Forsworns
Copy link
Contributor Author

Forsworns commented Jun 29, 2022 •
edited
Loading

I found this in the Developer’s Certificate of Origin

Use your real name (sorry, no pseudonyms or anonymous contributions.)

So I choose to use my real name. Apparently, Forsworns is simply a pseudonyms from The Elder Scrolls V: Skyrim... Maybe I need to change the git config locally, I'll check it.

I add a new GPG key to my account with my real name, it should work now

Forsworns added 2 commits June 29, 2022 22:03
@Forsworns
fix: misalignment in execve_map
ef9e108 
1. add alignment checker for both key and value of execve_map

2. append missing details on namespace and capacibilities for running processes during initialization

close: cilium#205

Signed-off-by: Peihao Yang <[email protected]>
@Forsworns
refactor: remove deprecated structs
501b511 
the ExecveValueL is no longer used in the Tetragon

Signed-off-by: Peihao Yang <[email protected]>
tpapagian
tpapagian approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@tpapagian tpapagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Forsworns
Copy link
Contributor Author

Thanks for your patient reviews and helps :) Recently I'm reading the Tetragon code, and find it a marvellous project

@jrfastab jrfastab merged commit fce26ac into cilium:main Jun 30, 2022
@jrfastab
Copy link
Contributor

Nice fix thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpapagian tpapagian tpapagian approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab jrfastab is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix execve_map_value in alignchecker
3 participants
@Forsworns @tpapagian @jrfastab