helm/rbac: split crd create permissions #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the k8s RBAC documentation:
Note: You cannot restrict create or deletecollection requests by their resource name.
For create, this limitation is because the name of the new object may not be known at
authorization time.
This was causing our operator to fail because it the "create" verb was restricted in the
resource name which was not known ahead of time. To fix this, we need to split out the
"create" permission such that it is not restricted by resourceNames. We can keep the other
CRD permissions as-is.
Logs from operator before this change:
level=fatal msg="Unable to register CRDs" error="Unable to create custom resource
definition: customresourcedefinitions.apiextensions.k8s.io is forbidden: User
\"system:serviceaccount:kube-system:tetragon\" cannot create resource
\"customresourcedefinitions\" in API group \"apiextensions.k8s.io\" at the cluster
scope" subsys=tetragon-operator
Signed-off-by: William Findlay <[email protected]>
michi-covalent
approved these changes
Jun 28, 2022
kkourt
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the k8s RBAC documentation:
This was causing our operator to fail because it the "create" verb was restricted in the
resource name which was not known ahead of time. To fix this, we need to split out the
"create" permission such that it is not restricted by resourceNames. We can keep the other
CRD permissions as-is.
Logs from operator before this change:
Signed-off-by: William Findlay [email protected]