-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add event_config alignment check #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Forsworns! Can you please rebase and drop the second commit (i.e. "Merge branch 'cilium:main' into alignchecker_event_config").
Additionally, in tetragon/pkg/api/processapi/processapi.go Lines 136 to 140 in 77e32bf
Using this, the alignchecker does not only check the size of the struct but also the fields inside. |
Regarding the check between |
In fact, they are shared. In See
and
Maybe it's better to append the missing items to |
I agree, maybe it is not enough to add new fields there, but we should also initialise them properly. I propose to keep that to a separate PR, so feel free to create a new one to solve this. Thanks! |
Created #205 to keep track of |
2a0b9e7
to
04262a5
Compare
|
04262a5
to
7c31683
Compare
declare a dummy event_config struct in bpf_alignchecker and check it in alignchecker.go Close cilium#108 Signed-off-by: Peihao Yang <peihao.young@gmail.com>
7c31683
to
b61cecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Thanks @Forsworns nice set of work. |
Take the issue #108 . Have tested locally.
BTW, the alignment-checker reminds me that
Is this expected? I found that they are defined as
and
Apparently, they are not the same...
And another related
ExecveValueL
struct inpkg/sensors/exec/execvemap/execve.go
seems deprectated.