readme: fix minor issues in quickstart #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue 1: the xwing pod uses busybox whoami which doesn't support --version, making the exit code wrong. To fix this let's just remove the --version argument. Issue 2: Grammar fix in examples. Issue 3: "Incorrectly read, malicious altered" -> "Incorrectly read, maliciously altered" Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/update-quick-start
branch
from
ecdd029 to
5394f98
Compare
michi-covalent
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: the xwing pod uses busybox whoami which doesn't support --version, making the
exit code wrong. To fix this let's just remove the --version argument.
Issue 2: Grammar fix in examples.
Issue 3: "Incorrectly read, malicious altered" -> "Incorrectly read, maliciously altered"
Signed-off-by: William Findlay [email protected]