metrics: Do not process the same map multiple times #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
added
the
release-note/misc
tpapagian
force-pushed
the
pr/apapag/fix_maps_metric
branch
from
f10f45a to
fa81867
Compare
For tetragon_map_in_use_gauge metric, we iterate through sensors.AllMaps
to provide their size and errors.
Depending on the sensors that are loaded and the dependencies between them,
sensors.AllMaps may have the same map name multiple times. This can cause in
errors like:
collected metric "XXX" {...} was collected before with the same name and label values
To avoid that we keep a map and we process each map only once.
Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
force-pushed
the
pr/apapag/fix_maps_metric
branch
from
fa81867 to
6788ed9
Compare
lambdanis
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
tetragon_map_in_use_gaugemetric, we iterate throughsensors.AllMapsto provide their size and errors.Depending on the sensors that are loaded and the dependencies between them,
sensors.AllMapsmay have the same map name multiple times. This can cause errors like:collected metric "XXX" {...} was collected before with the same name and label valuesTo avoid that we keep a map and process each map only once.