-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: libbpf removal #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
force-pushed
the
libbpf_removal
branch
2 times, most recently
from
July 1, 2022 12:25
3ce82cb
to
6798e03
Compare
kkourt
added
needs-rebase
This PR needs to be rebased because it has merge conflicts.
labels
Jul 11, 2022
olsajiri
force-pushed
the
libbpf_removal
branch
2 times, most recently
from
July 12, 2022 10:14
c854074
to
69af0e8
Compare
There's no need for it anymore cilium/ebpf loader, it's not used. Signed-off-by: Jiri Olsa <[email protected]>
With the new cilium/ebpf loader there's on need to keep it there, it's not used. Signed-off-by: Jiri Olsa <[email protected]>
Switching from current bpf.BTF to cilium/epbf btf.Spec package, which affects following places: - the pkg/btf/btf.go package is used to cache *btf.Spec object and red it from proper btf path (observerFindBTF) - ValidateKprobeSpec now takes *btf.Spec object and compares spec against it using cilium/ebpf btf interface - Removing FreeCachedBTF because btf.Spec does not have removal function, it will go down with the app Signed-off-by: Jiri Olsa <[email protected]>
Removing btf package under pkg/bpf which used libbpf to allow dump and get BTF types. Removing following headers becase they are not needed anymore: - pkg/bpf/btf.h - pkg/bpf/libbpf.h - pkg/bpf/libbpf__bpf.h - pkg/bpf/libbpf_common.h - pkg/bpf/uapi-linux-btf.h The original change was made by Jussi, kkeping his SOB. Signed-off-by: Jussi Maki <[email protected]> Signed-off-by: Jiri Olsa <[email protected]> fix
Removing all remaining references to libbpf and LD_LIBRARY_PATH. The original change was made by Jussi, kkeping his SOB. Signed-off-by: Jussi Maki <[email protected]> Signed-off-by: Jiri Olsa <[email protected]>
Adding fetch-testdata make target to retrieve vmlinux for pkg/btf tests. Signed-off-by: Jiri Olsa <[email protected]>
jrfastab
removed
the
needs-rebase
This PR needs to be rebased because it has merge conflicts.
label
Jul 14, 2022
kkourt
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the last usage of libbpf.
Signed-off-by: Jiri Olsa [email protected]