Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: libbpf removal #199

Merged
merged 6 commits into from
Jul 26, 2022
Merged

tetragon: libbpf removal #199

merged 6 commits into from
Jul 26, 2022

Conversation

olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Jun 28, 2022

Removing the last usage of libbpf.

Signed-off-by: Jiri Olsa [email protected]

@olsajiri olsajiri force-pushed the libbpf_removal branch 2 times, most recently from 3ce82cb to 6798e03 Compare July 1, 2022 12:25
@olsajiri olsajiri changed the title libbpf removal tetragon: libbpf removal Jul 1, 2022
@kkourt kkourt added needs-rebase This PR needs to be rebased because it has merge conflicts. labels Jul 11, 2022
@olsajiri olsajiri force-pushed the libbpf_removal branch 2 times, most recently from c854074 to 69af0e8 Compare July 12, 2022 10:14
olsajiri added 6 commits July 13, 2022 14:54
There's no need for it anymore cilium/ebpf loader, it's not used.

Signed-off-by: Jiri Olsa <[email protected]>
With the new cilium/ebpf loader there's on need to keep it there,
it's not used.

Signed-off-by: Jiri Olsa <[email protected]>
Switching from current bpf.BTF to cilium/epbf btf.Spec package,
which affects following places:

  - the pkg/btf/btf.go package is used to cache *btf.Spec object
    and red it from proper btf path (observerFindBTF)

  - ValidateKprobeSpec now takes *btf.Spec object and compares spec
    against it using cilium/ebpf btf interface

  - Removing FreeCachedBTF because btf.Spec does not have removal function,
    it will go down with the app

Signed-off-by: Jiri Olsa <[email protected]>
Removing btf package under pkg/bpf which used libbpf to
allow dump and get BTF types.

Removing following headers becase they are not needed anymore:

  - pkg/bpf/btf.h
  - pkg/bpf/libbpf.h
  - pkg/bpf/libbpf__bpf.h
  - pkg/bpf/libbpf_common.h
  - pkg/bpf/uapi-linux-btf.h

The original change was made by Jussi, kkeping his SOB.

Signed-off-by: Jussi Maki <[email protected]>
Signed-off-by: Jiri Olsa <[email protected]>

fix
Removing all remaining references to libbpf and LD_LIBRARY_PATH.

The original change was made by Jussi, kkeping his SOB.

Signed-off-by: Jussi Maki <[email protected]>
Signed-off-by: Jiri Olsa <[email protected]>
Adding fetch-testdata make target to retrieve vmlinux for pkg/btf tests.

Signed-off-by: Jiri Olsa <[email protected]>
@olsajiri olsajiri marked this pull request as ready for review July 13, 2022 13:53
@olsajiri olsajiri requested a review from a team as a code owner July 13, 2022 13:53
@olsajiri olsajiri requested a review from jrfastab July 13, 2022 13:53
@jrfastab jrfastab removed the needs-rebase This PR needs to be rebased because it has merge conflicts. label Jul 14, 2022
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants