podinfo: Handle an expected error gracefully #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes creating a podinfo fails with AlreadyExists error even though the previous call to get the podinfo returned NotFound because of a timing issue. Requeue without returning the error when this happens to prevent the controller from logging an unnecessary error. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added
the
release-note/misc
sayboras
approved these changes
Nov 21, 2023
| // previous call to Get returned "NotFound" because of a timing issue. | ||
| // Requeue without returning the error when this happens, otherwise | ||
| // the controller logs an error. | ||
| return ctrl.Result{Requeue: true}, nil |
There was a problem hiding this comment.
yeah so the idea is to requeue so that the reconciler exercises the update path the next time around, just to make sure the podinfo has all the up-to-date information.
willfindlay
approved these changes
Nov 21, 2023
lambdanis
added
release-note/minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes creating a podinfo fails with AlreadyExists error even though the previous call to get the podinfo returned NotFound because of a timing issue. Requeue without returning the error when this happens to prevent the controller from logging an unnecessary error.