Fixes to pass VSCode Intellisence checks #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevsecurity
force-pushed
the
pr/kevsecurity/vscode-fixes
branch
2 times, most recently
from
9e989d0 to
7a72a95
Compare
willfindlay
approved these changes
Jun 16, 2022
Great, can you merge? I'm not authorized. |
|
@kevsecurity Actually one thing, maybe we should document the #ifdef VSCODE stuff somewhere as well as maybe add a comment in that file to explain what it's doing there? |
Actually good point. The commit comment probably isn't sufficient. I'll do that and push. |
Often, the attribute((section())) statement was used with an extra set of parentheses around the section name. This caused issues for VSCode and resulted in the files being marked as having errors, making it harder to spot actual errors. This commit removes the extra parentheses. It also adds a #define for '''__builtin_preserve_access_index()''' if VSCODE has been defined. This allows developers to define VSCODE in their VSCODE C/C++ settings in order to stop Intellisense complaining about the _(P) macro which is used in probe_read() calls. Signed-off-by: Kevin Sheldrake <[email protected]>
kevsecurity
force-pushed
the
pr/kevsecurity/vscode-fixes
branch
from
7a72a95 to
cda33da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, the attribute((section())) statement was used with an extra
set of parentheses around the section name. This caused issues for
VSCode and resulted in the files being marked as having errors, making
it harder to spot actual errors.
This commit removes the extra parentheses. It also adds a #define for
'''__builtin_preserve_access_index()''' if VSCODE has been defined. This
allows developers to define VSCODE in their VSCODE C/C++ settings in
order to stop Intellisense complaining about the _(P) macro which is
used in probe_read() calls.
Signed-off-by: Kevin Sheldrake [email protected]