codegen misc #162
Merged
codegen misc #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
force-pushed
the
pr/kkourt/codegen-misc
branch
2 times, most recently
from
d32ef6e to
738c467
Compare
willfindlay
approved these changes
Jun 17, 2022
yap, that's the plan :) |
... and, also, do it in parallel. Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
update codegen to deal with paths that are not part of the code being generated. Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
There is no need to generate code for stringmatcher. Just move it to a package and use it as normal go code. Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
There is no need to generate code for bytesmatcher. Just move it to a package and use it as normal go code. Signed-off-by: Kornilios Kourtis <[email protected]>
There is no need to generate code for durationmatcher. Just move it to a package and use it as normal go code. Signed-off-by: Kornilios Kourtis <[email protected]>
There is no need to generate code for durationmatcher. Just move it to a package and use it as normal go code Signed-off-by: Kornilios Kourtis <[email protected]>
There is no need to generate code for timestampmatcher. Just move it to a package and use it as normal go code Signed-off-by: Kornilios Kourtis <[email protected]>
Now that there are no more matchers generated, we can remove the matchers package from codegen. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
force-pushed
the
pr/kkourt/codegen-misc
branch
from
0b455ba to
37775ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codegen misc updates, pleas see commits.