Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Fix retkprobe loading on 4.19 #151

Merged
merged 3 commits into from
Jun 11, 2022

Conversation

olsajiri
Copy link
Contributor

Fixing loading of retkprobe with moving args pointer initialization
closer to the user to workaround clang being smart and breaking
verifier.

Signed-off-by: Jiri Olsa [email protected]

olsajiri added 3 commits June 10, 2022 20:32
Using args offset in copy_char_buf instead of the direct pointer.
It will be needed in following changes, where we need to store
pointer into args, but we can't do that directly.

Signed-off-by: Jiri Olsa <[email protected]>
Using args offset in copy_char_iovec instead of the direct pointer.
It will be needed in following changes, where we need to store pointer
into args, but we can't do that directly.

Signed-off-by: Jiri Olsa <[email protected]>
Moving the args pointer initialization closer to the
user to workaround clang being smart and breaking
verifier.

Signed-off-by: Jiri Olsa <[email protected]>
@olsajiri olsajiri force-pushed the retkprobe_verifier_fix_419 branch from 0362d25 to 9a9bb3e Compare June 10, 2022 18:33
@willfindlay willfindlay self-requested a review June 10, 2022 18:57
Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to reproduce the problem on 4.19.179 and confirmed this fixes it.

@olsajiri olsajiri marked this pull request as ready for review June 10, 2022 21:01
@olsajiri olsajiri requested a review from a team as a code owner June 10, 2022 21:01
@jrfastab jrfastab merged commit 8598f84 into cilium:main Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants