-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Clean up Helm values #1501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/what-is-tetragon-operator
branch
from
September 21, 2023 21:51
68b690b
to
a26307e
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michi-covalent
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Sep 21, 2023
michi-covalent
force-pushed
the
pr/michi/what-is-tetragon-operator
branch
3 times, most recently
from
September 21, 2023 23:09
bc7538d
to
64a76d9
Compare
michi-covalent
force-pushed
the
pr/michi/what-is-tetragon-operator
branch
2 times, most recently
from
September 21, 2023 23:38
1595b8d
to
5d6caf6
Compare
lambdanis
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner thanks ❤️
- Remove tetragonOperator.enabled. Tetragon daemonset won't start if this value is set to false. - Rename podWatcher.enabled to tetragonOperator.podInfo.enabled to better indicate this enables PodInfo CRD. - Always run Tetragon operator deployment. We are planning to remove the init container, so the operator needs to run unconditionally to create CRDs. - Rename skip-tetragon-pod-crd to skip-pod-info-crd in tetragon-operator configmap. The operator is expecting skip-pod-info-crd flag. - Don't start the PodInfo controller if tetragonOperator.podInfo.enabled is set to false. Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/what-is-tetragon-operator
branch
from
September 22, 2023 15:00
5d6caf6
to
2cc7f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this value is set to false.
better indicate this enables PodInfo CRD.
init container, so the operator needs to run unconditionally to create
CRDs.
configmap. The operator is expecting skip-pod-info-crd flag.
is set to false.