Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Clean up Helm values #1501

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Sep 21, 2023

  • Remove tetragonOperator.enabled. Tetragon daemonset won't start if
    this value is set to false.
  • Rename podWatcher.enabled to tetragonOperator.podInfo.enabled to
    better indicate this enables PodInfo CRD.
  • Always run Tetragon operator deployment. We are planning to remove the
    init container, so the operator needs to run unconditionally to create
    CRDs.
  • Rename skip-tetragon-pod-crd to skip-pod-info-crd in tetragon-operator
    configmap. The operator is expecting skip-pod-info-crd flag.
  • Don't start the PodInfo controller if tetragonOperator.podInfo.enabled
    is set to false.

@michi-covalent michi-covalent force-pushed the pr/michi/what-is-tetragon-operator branch from 68b690b to a26307e Compare September 21, 2023 21:51
@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 1595b8d
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/650cd37ee7f3330008cfaece
😎 Deploy Preview https://deploy-preview-1501--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Sep 21, 2023
@michi-covalent michi-covalent force-pushed the pr/michi/what-is-tetragon-operator branch 3 times, most recently from bc7538d to 64a76d9 Compare September 21, 2023 23:09
@michi-covalent michi-covalent force-pushed the pr/michi/what-is-tetragon-operator branch 2 times, most recently from 1595b8d to 5d6caf6 Compare September 21, 2023 23:38
@michi-covalent michi-covalent marked this pull request as ready for review September 21, 2023 23:38
@michi-covalent michi-covalent requested review from a team and willfindlay as code owners September 21, 2023 23:38
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner thanks ❤️

install/kubernetes/templates/operator_clusterrole.yaml Outdated Show resolved Hide resolved
install/kubernetes/templates/operator_serviceaccount.yaml Outdated Show resolved Hide resolved
- Remove tetragonOperator.enabled. Tetragon daemonset won't start if
  this value is set to false.
- Rename podWatcher.enabled to tetragonOperator.podInfo.enabled to
  better indicate this enables PodInfo CRD.
- Always run Tetragon operator deployment. We are planning to remove the
  init container, so the operator needs to run unconditionally to create
  CRDs.
- Rename skip-tetragon-pod-crd to skip-pod-info-crd in tetragon-operator
  configmap. The operator is expecting skip-pod-info-crd flag.
- Don't start the PodInfo controller if tetragonOperator.podInfo.enabled
  is set to false.

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent force-pushed the pr/michi/what-is-tetragon-operator branch from 5d6caf6 to 2cc7f99 Compare September 22, 2023 15:00
@michi-covalent michi-covalent merged commit 22a9fe8 into main Sep 22, 2023
@michi-covalent michi-covalent deleted the pr/michi/what-is-tetragon-operator branch September 22, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants