observer_test_helper: make helpers generic over TB #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testing package supports additional test types, such as fuzzing and bench testing. However, our existing observer test helpers were designed only to work with unit tests. To support additional test types, modify the observer test helpers to use the generic testing.TB interface instead of testing.T. This should facilitate writing fuzz tests and benchmarks for Tetragon in the future. Signed-off-by: William Findlay <[email protected]>
willfindlay
added
the
release-note/misc
tpapagian
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing package supports additional test types, such as fuzzing and bench testing. However, our existing observer test helpers were designed only to work with unit tests. To support additional test types, modify the observer test helpers to use the generic testing.TB interface instead of testing.T. This should facilitate writing fuzz tests and benchmarks for Tetragon in the future.