Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix footer #1404

Merged
merged 1 commit into from
Sep 5, 2023
Merged

docs: fix footer #1404

merged 1 commit into from
Sep 5, 2023

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Aug 30, 2023

Fixes: #1395

@kkourt kkourt requested review from mtardy and a team as code owners August 30, 2023 08:50
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 3a59e7e
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/64f6c469f1283e00087f33b0
😎 Deploy Preview https://deploy-preview-1404--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Aug 30, 2023
@mtardy mtardy requested a review from xmulligan September 4, 2023 09:26
docs/layouts/partials/footer.html Outdated Show resolved Hide resolved
docs/layouts/partials/footer.html Show resolved Hide resolved
docs/assets/scss/footer.scss Outdated Show resolved Hide resolved
Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt
Copy link
Contributor Author

kkourt commented Sep 5, 2023

Thanks, added suggestions.

@mtardy
Copy link
Member

mtardy commented Sep 5, 2023

we need to fix the size the header and the footer takes on the docs pages
image

on a "normal" MacBook screen it's like 30% taken by those which is a bit annoying, but this is a task for later :)

Thanks kornilios!

@mtardy mtardy merged commit f3f582b into main Sep 5, 2023
@mtardy mtardy deleted the pr/kkourt/footer branch September 5, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update homepage footer
2 participants