codegen/helpers: fix name inference for oneof codegen #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach we were using, converting the Oneof field type using
strcase.ToScreamingSnake() was fundamentally broken for types that include e.g. a number
immediately next to a letter in the type name.
For example, consider something like:
message FooEvent42 { /* ... */ }
oneof event {
ProcessExec process_exec = 1;
ProcessExit process_exit = 5;
ProcessKprobe process_kprobe = 9;
ProcessTracepoint process_tracepoint = 10;
ProcessDns process_dns = 14;
FooEvent42 foo_event42 = 15;
Test test = 40000;
}
The name for the oneof according to our codegen would be wrong: FOO_EVENT_42 instead of
FOO_EVENT42. To fix this, we can just grab the name of the actual oneof field and apply
a simple strings.ToUpper() transformation to it. This then results in the correct name
FOO_EVENT42.
Signed-off-by: William Findlay <[email protected]>
This was producing false positives when including code snippets in patch messages.
For example, you can imagine a Go code snippet like:
typedef foo struct {
test Test
}
Line 2 would produce a false positive due to the repetition of "test". Let's
remove this lint since it's mostly useless anyway.
Signed-off-by: William Findlay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach we were using, converting the Oneof field type using
strcase.ToScreamingSnake() was fundamentally broken for types that include e.g. a number
immediately next to a letter in the type name.
For example, consider something like:
The name for the oneof according to our codegen would be wrong: FOO_EVENT_42 instead of
FOO_EVENT42. To fix this, we can just grab the name of the actual oneof field and apply
a simple strings.ToUpper() transformation to it. This then results in the correct name
FOO_EVENT42.
Signed-off-by: William Findlay [email protected]