-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha: add pr-validation GH action #1384
Conversation
This action validates PRs based on labels. It blocks PRs that have a dont-merge/* label, and blocks PRs that do not have a release-note/* labe. Signed-off-by: Kornilios Kourtis <[email protected]>
Do you think all PRs should be labeled with some sort of release-note label? |
yes. that's the point of this PR. It can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i love dont-merge labels 🥰
Could we maybe ignore bot-related PR for those validations? Not sure we need release notes for deps bumps, for example #1397. I see two things:
|
we should just configure renovate to add a label, maybe |
See #1384 (comment) and #1384 (comment). Signed-off-by: Mahé <[email protected]>
See #1384 (comment) and #1384 (comment). Signed-off-by: Mahé <[email protected]>
See #1384 (comment) and #1384 (comment). Signed-off-by: Mahé <[email protected]>
This action validates PRs based on labels.
It blocks PRs that have a dont-merge/* label, and blocks PRs that do not have a release-note/* labe.