Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't truncate Ktime to milliseconds #136

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Don't truncate Ktime to milliseconds #136

merged 1 commit into from
Jun 8, 2022

Conversation

sharlns
Copy link
Contributor

@sharlns sharlns commented Jun 8, 2022

Don't truncate Ktime to milliseconds and give a higher resolution. Fix for #124.

@sharlns sharlns requested a review from a team as a code owner June 8, 2022 00:40
@sharlns sharlns requested a review from tpapagian June 8, 2022 00:40
@sharlns sharlns force-pushed the fix_ktime_millisec branch from 62d4ada to 5d371eb Compare June 8, 2022 00:45
@michi-covalent
Copy link
Contributor

the change itself looks good to me. could you update the commit message to something like:

Don't truncate Ktime to milliseconds 

Report event timestamp in nanoseconds to give a higher resolution.

Fixes #124

Signed-off-by: Natalia Reka Ivanko <[email protected]>

also, you don't need to change it for this pr, but in general use pr/$github_username/ prefix for pull request branches.

Report event timestamp in nanoseconds to give a higher resolution.

Fixes #124

Signed-off-by: Natalia Reka Ivanko <[email protected]>
@sharlns sharlns force-pushed the fix_ktime_millisec branch from 5d371eb to c86deff Compare June 8, 2022 15:32
@sharlns sharlns merged commit 469bddb into main Jun 8, 2022
@sharlns sharlns deleted the fix_ktime_millisec branch June 8, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants