Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move readConfig{Dir,File} to the option package #1336

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

michi-covalent
Copy link
Contributor

Move readConfig{Dir,File} to the option package. I'd like to use these functions to read tetragon operator configurations.

Ref: #794

Move readConfig{Dir,File} to the option package. I'd like to use these
functions to read tetragon operator configurations.

Ref: #794

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent marked this pull request as ready for review August 8, 2023 21:49
@michi-covalent michi-covalent requested a review from a team as a code owner August 8, 2023 21:49
@michi-covalent michi-covalent requested a review from olsajiri August 8, 2023 21:49
Copy link
Member

@tixxdz tixxdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! maybe have /etc/tetragon/operator.conf.d/ for its config ? if that works...

@michi-covalent
Copy link
Contributor Author

michi-covalent commented Aug 8, 2023

Great! maybe have /etc/tetragon/operator.conf.d/ for its config ? if that works...

yeah that's the idea. opening a followup PR soon 🚀

edit: #1337 🥰

@michi-covalent michi-covalent merged commit 181cffd into main Aug 8, 2023
@michi-covalent michi-covalent deleted the pr/michi/refactor branch August 8, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants