codegen: codegen generic event and response interfaces + usability improvements for helpers.pb.go #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willfindlay needs a rebase thanks! |
This enables us to place codegen in different places, including the base directory where gRPC codegen goes. In turn this allows us to extend the base API package with additional types. Signed-off-by: William Findlay <[email protected]>
This file contains two interfaces that make it easier to work with Tetragon API types, namely Event messages and GetEventsResponse oneofs. Signed-off-by: William Findlay <[email protected]>
Use the new Event interface generated in previous commits in the eventchecker. This enables compile-time typechecking in methods that use the Event interface. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/codegen-type-helpers
branch
from
e813de1 to
3b48d64
Compare
|
Bad rebase, fixing now. |
This commit improves the helpers API to make naming more consistent and refactors it to use the new code generated event interfaces we introduced earlier in this series. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/codegen-type-helpers
branch
from
3b48d64 to
d94f202
Compare
|
@jrfastab should be good to go |
kkourt
approved these changes
Jun 10, 2022
| @@ -269,7 +269,7 @@ func CheckerFromResponse(response *tetragon.GetEventsResponse) (EventChecker, er | |||
| } | |||
|
|
|||
| // Event is an empty interface used for events like ProcessExec, etc. | |||
| type Event interface{} | |||
| type Event tetragon.Event | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight refactors to make the codegen API more usable, especially around helpers.pb.go. In particular, we remove all the blank interfaces and replace them with sane types that enable compile-time type checking.
Please see individual commit messages.