tetragon: remove unnecessary GetProcessCopy() #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetProcessCopy is required when we need to modify the Process info. This is done primarily to update the Tid to reflect the caller of a system call or kprobe. Most other cases shouldn't need to get a fully copy of the process object. The reason a copy is needed in the modification case is to avoid having a writer updating the object while the GRPC stream handler or JSON writer are marshalling the data which can corrupt the streaming logic. This results in either broken messages in JSON export file or the GRPC stream failing. Signed-off-by: John Fastabend <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
reviewed
Jul 20, 2023
pkg/grpc/exec/exec.go
Outdated
| if !msg.RefCntDone[ProcessRefCnt] { | ||
| internal.RefDec() | ||
| msg.RefCntDone[ProcessRefCnt] = true | ||
| } | ||
| proc := internal.GetProcessCopy() |
There was a problem hiding this comment.
should we keep the copy in here? there's tid update on the next line
There was a problem hiding this comment.
I will update this part so we just use the tid of the exec time or pid as tid, without doing this extra copy , and this code will just make it an assertion of what we get from bpf side...
For keeping the copy or do not evict from cache before we return the event, I have to check the code , no idea now
There was a problem hiding this comment.
For this patch I'll put that Copy() back so its correct. We can remove them with future solution.
jrfastab
force-pushed
the
pr/jrfastab/deepCopyRemove
branch
from
536e66d to
71fee44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetProcessCopy is required when we need to modify the Process info. This is done primarily to update the Tid to reflect the caller of a system call or kprobe.
Most other cases shouldn't need to get a fully copy of the process object. The reason a copy is needed in the modification case is to avoid having a writer updating the object while the GRPC stream handler or JSON writer are marshalling the data which can corrupt the streaming logic. This results in either broken messages in JSON export file or the GRPC stream failing.