eventchecker: simplify yaml spec for eventchecker #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a private helper struct to replace the old eventchecker spec and use it to codegen an UnmarshalJSON and MarshalJSON implementation for a wrapper struct around the EventChecker interface. This enables seamless marshaling and unmarshaling of the underlying interface and a much cleaner API. It may be possible to do something similar for MultiEventChecker but details are TBD around what might look like. Signed-off-by: William Findlay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a private helper struct to replace the old eventchecker spec and use it to codegen
an UnmarshalJSON and MarshalJSON implementation for a wrapper struct around the
EventChecker interface. This enables seamless marshaling and unmarshaling of the
underlying interface and a much cleaner API.
It may be possible to do something similar for MultiEventChecker but details are TBD
around what might look like.
Signed-off-by: William Findlay [email protected]