tetragon: extract protobuf from the dns cache #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing to use Cilium to fetch DNS names (lost in conversion to OSS) we have the dns pkg pulling in protobufs. This is a bit odd and not ideal because Cilium certainly doesn't care about Tetragon protobufs and importing them and using them in Cilium side is awkward. For now do some simple refactoring to clean up the API. Signed-off-by: John Fastabend <[email protected]>
willfindlay
approved these changes
Jun 2, 2022
michi-covalent
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing to use Cilium to fetch DNS names (lost in conversion to OSS) we
have the dns pkg pulling in protobufs. This is a bit odd and not ideal
because Cilium certainly doesn't care about Tetragon protobufs and
importing them and using them in Cilium side is awkward.
For now do some simple refactoring to clean up the API.
Signed-off-by: John Fastabend [email protected]