tetragon: Pull Default loader out of observer #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The observer shouldn't care what programs are being loaded as part of the default. This allows us to have different commands run different default setups. One idea here is we can build a stack trace tool with just the needed stack tracing Or profiling tool with a set of profiling defaults. This patch moves the default handler out of observer as a first step and puts it in the cmd that is launching the observer. Signed-off-by: John Fastabend <[email protected]>
willfindlay
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The observer shouldn't care what programs are being loaded as part of the
default. This allows us to have different commands run different default
setups. One idea here is we can build a stack trace tool with just the
needed stack tracing Or profiling tool with a set of profiling defaults.
This patch moves the default handler out of observer as a first step and
puts it in the cmd that is launching the observer.
Signed-off-by: John Fastabend [email protected]