codegen: use new cilium-builder image #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like our custom codegen for Go 1.18 is broken. I'll file a separate PR to fix and then we can rebase this. |
rolinh
force-pushed
the
pr/rolinh/codegen-new-cilium-builder
branch
from
42813f7 to
32552c2
Compare
willfindlay
approved these changes
May 31, 2022
The new cilium-builder image embeds the protoc-gen-doc plugin. This means that we don't need a separate `doc` target as documentation is generated along with the code. Signed-off-by: Robin Hahling <[email protected]>
rolinh
force-pushed
the
pr/rolinh/codegen-new-cilium-builder
branch
from
32552c2 to
b3e91f8
Compare
kaworu
approved these changes
Jun 1, 2022
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new cilium-builder image embeds the protoc-gen-doc plugin. This means that we don't need a separate
doctarget as documentation is generated along with the code.