Update description of CRD parameters #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furisto
force-pushed
the
pr/furisto/update-crd-documentation
branch
from
13784dd to
dd2cbda
Compare
kkourt
reviewed
May 31, 2022
There was a problem hiding this comment.
Nice catch! Thanks!
I have some suggestions that seem like an improvement to me, what do you think?
CC: @tpapagian
pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpolicies.yaml
Outdated
Show resolved
Hide resolved
pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpolicies.yaml
Outdated
Show resolved
Hide resolved
pkg/k8s/apis/cilium.io/client/crds/v1alpha1/cilium.io_tracingpolicies.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Schubart <[email protected]>
Furisto
force-pushed
the
pr/furisto/update-crd-documentation
branch
from
dd2cbda to
62c2a67
Compare
|
@kkourt Sounds good! I have made the changes as requested with the exception of using Mnt instead of Mount, because this is how the input value is expected for mount namespaces. |
Thanks both for the changes and for catching Mnt vs Mount! Looks good from my side! |
kkourt
approved these changes
May 31, 2022
|
Nice catch, thanks. Thanks also for applying @kkourt's comments. |
tpapagian
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure if I understood everything correctly, but based on the examples in the crds directory the current descriptions do not seem to reflect the expected input.