tests: split json checker out of observer #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
force-pushed
the
pr/willfindlay/split-json-checker
branch
from
9b89de7 to
494d9cc
Compare
willfindlay
force-pushed
the
pr/willfindlay/split-json-checker
branch
from
494d9cc to
a7db0f2
Compare
JsonTestCheck is used widely by our unit tests, not just in pkg/observer. So let's split this functionality out of the observer to make things more modular. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/split-json-checker
branch
from
a7db0f2 to
928d70f
Compare
jrfastab
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonTestCheck is used widely by our unit tests, not just in pkg/observer. So let's split
this functionality out of the observer to make things more modular.
Signed-off-by: William Findlay [email protected]