tetragon: Remove extra Program and Map structs after split #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Jiri, seems so! good catch I was also adding stuff to the wrong struct... so maybe this one too ? |
|
@tixxdz aah right, I did not check on State ;-) yea, looks like it could be removed.. I'll try that, thanks |
We ended up with 2 Program, Map and State structs (and related functions) after the pkg/sensors/program split [1], removing them. [1] f227832 tetragon: Create a pkg/sensors/program to split up sensors Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
program_split_fix
branch
from
1873709 to
8c48ca7
Compare
|
Yep LGTM that was my refactoring gone slightly off thanks. |
jrfastab
approved these changes
May 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ended up with 2 Program and Map structs (and related functions)
after the pkg/sensors/program split [1], removing them.
I might be missing some point why we have this, but it builds and tests
pass ;-) I only noticed this because my other change added new field
to wrong Program struct.
[1] f227832 tetragon: Create a pkg/sensors/program to split up sensors
Signed-off-by: Jiri Olsa [email protected]