Fix release scripts for arm64 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
requested review from
jschwinger233 and
tklauser
and removed request for
jschwinger233
tklauser
reviewed
Jul 5, 2023
|
|
||
| test -d release/${OS}/${ARCH} || mkdir -p release/${OS}/${ARCH} | ||
| tar -czf release/pwru-${OS}-${ARCH}.tar.gz pwru | ||
| (cd release && sha256sum pwru-${OS}-${ARCH}.tar.gz > pwru-${OS}-${ARCH}.tar.gz.sha256sum) |
There was a problem hiding this comment.
Maybe we can try goreleaser in the future 😃
There was a problem hiding this comment.
As long as it's able to statically link with CGO, I am all in 😄
jschwinger233
approved these changes
Jul 6, 2023
Otherwise, running "GOARCH=arm64 go generate build.go" results into cross-compiling bpf2go for arm64 when running on a amd64 host. Fixes: 62d0dff ("main: pass -target to bpf2go") Signed-off-by: Martynas Pumputis <[email protected]>
For example:
LIBPCAP_ARCH=aarch64-unknown-linux-gnu LIBPCAP_CC=aarch64-linux-gnu-gcc make libpcap/libpcap.a
Signed-off-by: Martynas Pumputis <[email protected]>
Signed-off-by: Martynas Pumputis <[email protected]>
Signed-off-by: Martynas Pumputis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested locally by running
make release.Fix #212