configdump: remove duplicates in networkpolicies config dump #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the networkpolicies in the Envoy config dump contains duplicates. The reason is that the networkpolicies are stored per endpoint ip. Iterating over the policies need to take this into account. Therefore, this commit introduces a filter based on the endpoint id of the policy. Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
force-pushed
the
pr/mhofstetter/networkpolicies-dump-duplicates
branch
from
5f5c10a to
7ac87df
Compare
jrajahalme
approved these changes
Sep 14, 2023
mhofstetter
added a commit
to mhofstetter/cilium
that referenced
this pull request
Sep 14, 2023
This commit updates the Cilium Proxy (go.mod, Cilium Agent Dockerfile & Helm Chart) to the latest version. This includes the fix cilium/proxy#352 that fixes duplicated NetworkPolicies in the Envoy Config Dump. Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
deleted the
pr/mhofstetter/networkpolicies-dump-duplicates
branch
sayboras
pushed a commit
to cilium/cilium
that referenced
this pull request
Sep 19, 2023
This commit updates the Cilium Proxy (go.mod, Cilium Agent Dockerfile & Helm Chart) to the latest version. This includes the fix cilium/proxy#352 that fixes duplicated NetworkPolicies in the Envoy Config Dump. Signed-off-by: Marco Hofstetter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the networkpolicies in the Envoy config dump contains duplicates.
The reason is that the networkpolicies are stored per endpoint ip (e.g. IPv4 & IPv6). Iterating over the policies need to take this into account.
Therefore, this commit introduces a filter based on the endpoint id of the policy.