-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong behavior on s390x #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! I left some nits, I'd appreciate if you could look into them. Other than that I'm happy to merge the PR.
Strictly speaking, bitfield order is defined by a respective arch ABI, however, in practice it always the same as byte order, and LLVM already makes use of this correlation, therefore do the same in here. Signed-off-by: Ilya Leoshkevich <[email protected]>
Signed-off-by: Ilya Leoshkevich <[email protected]>
Your proposals sound sane, looking forward to your update! |
I actually pushed one a few days back (3db7828) :-) Could you have a look please? |
Oh boy, sorry about that! I missed the notification somehow. Thanks for working on this! |
Update ebpf to include PR cilium/ebpf#91. The update is needed to fix opencontainers#2316. Signed-off-by: Alice Frosi <[email protected]>
Update ebpf to include PR cilium/ebpf#91. The update is needed to fix opencontainers#2316. Signed-off-by: Alice Frosi <[email protected]>
Update ebpf to include PR cilium/ebpf#91. The update is needed to fix opencontainers#2316. Signed-off-by: Alice Frosi <[email protected]>
Fixes #86