cli: Add support for helm --max-history command line flag

[marcofranssen]

Please ensure your pull request adheres to the following guidelines:

• For first time contributors, read Submitting a pull request
• All code is covered by unit and/or runtime tests where feasible.
• All commits contain a well written commit description including a title,
  description and a Fixes: #XXX line if the commit addresses a particular
  GitHub issue.
• If your commit description contains a Fixes: <commit-id> tag, then
  please add the commit author[s] as reviewer[s] to this issue.
• All commits are signed off. See the section Developer’s Certificate of Origin
• Provide a title or release-note blurb suitable for the release notes.
• Are you a user of Cilium? Please add yourself to the Users doc
• Thanks for contributing!

Fixes: N.A.

cli: Add support for helm --max-history command line flag

[gandro]

Thank you! Looks good to me. Introducing a limit on the history by default seems reasonable to me. But let's also ping @cilium/sig-cilium-cli

[gandro]

/test

[gandro]

@marcofranssen Please note that rebasing the branch invalidates the CI results, thus requiring us to restart CI. Unless there are persistent CI flakes that reoccur even after a comitter has restarted CI for you, or there are merge conflicts, there should be no need to rebase your branch.

[gandro]

/test

[marcofranssen]

@gandro ok, good to know. I'm very used to that to keep stuff in sync, but will remember this for other contributions on this project. To not do that if there is no need for the sake of that PR.

[gandro]

Incidentally the CI failures on the upgrade test look unrelated. Let's wait for them to get fixed before we rebase

[marcofranssen]

Pushed the fix for go linting just now. Was missing the license header on the upgrade_test.go.

The other failures seem to be unrelated to the CLI changes. Let me know if there is anything else required from me.

[gandro]

Thank you! For now, I don't think anything else is required from you. Let's re-run CI

[gandro]

/test

[gandro]

The test failiure on the the integration test workflow seems legitimate:

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃   PANIC  package: github.com/cilium/cilium/cilium-cli/install • TestMaxHistory   ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
panic: runtime error: invalid memory address or nil pointer dereference [recovered] 
	panic: runtime error: invalid memory address or nil pointer dereference             
[signal SIGSEGV: segmentation violation code=0x1 addr=0x118 pc=0x2ea95ef]           
                                                                                    
goroutine 54 [running]:                                                             
testing.tRunner.func1.2({0x324dda0, 0x7597110})                                     
	/opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1632 +0x230               
testing.tRunner.func1()                                                             
	/opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1635 +0x35e               
panic({0x324dda0?, 0x7597110?})                                                     
	/opt/hostedtoolcache/go/1.23.4/x64/src/runtime/panic.go:785 +0x132                  
github.com/cilium/cilium/cilium-cli/install.TestMaxHistory(0xc00046b6c0?)           
	/home/runner/work/cilium/cilium/cilium-cli/install/upgrade_test.go:21 +0x8f         
testing.tRunner(0xc00046b6c0, 0x4f1efb0)                                            
	/opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1690 +0xf4                
created by testing.(*T).Run in goroutine 1                                          
	/opt/hostedtoolcache/go/1.23.4/x64/src/testing/testing.go:1743 +0x390               
FAIL	github.com/cilium/cilium/cilium-cli/install	0.070s                

[marcofranssen]

Fixed

[julianwiedmann]

drive-by - please squash the two fix-ups into the main patch :)

[marcofranssen]

drive-by - please squash the two fix-ups into the main patch :)

Done! 🎉

[tklauser]

/test

[marcofranssen]

Looks like all checks passed :) are we good to merge?