Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway-api: Add required labels and annotations #33990

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

sayboras
Copy link
Member

This commit is to add the required label gateway-name e.g. gateway.networking.k8s.io/gateway-name, and propagate all labels and annotations from spec.infrastructure in all generated resources. The main goal is to conform with below GEP.

Relates: kubernetes-sigs/gateway-api#1757

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 24, 2024
@sayboras sayboras added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Jul 24, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 24, 2024
@sayboras
Copy link
Member Author

/ci-gateway-api

@sayboras
Copy link
Member Author

/test

@sayboras sayboras marked this pull request as ready for review July 24, 2024 13:34
@sayboras sayboras requested a review from a team as a code owner July 24, 2024 13:34
@sayboras sayboras added the needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch label Jul 24, 2024
@sayboras
Copy link
Member Author

sayboras commented Aug 6, 2024

/ci-gateway-api

@sayboras sayboras requested review from a team as code owners August 6, 2024 11:44
@sayboras sayboras requested review from aanm and tklauser August 6, 2024 11:44
@sayboras
Copy link
Member Author

sayboras commented Aug 6, 2024

/ci-gateway-api

@sayboras sayboras marked this pull request as draft August 6, 2024 11:44
@sayboras sayboras force-pushed the pr/tammach/gateway-api-label branch from 5211499 to 50b77da Compare August 6, 2024 12:19
This commit is to add the required label gateway-name e.g.
`gateway.networking.k8s.io/gateway-name`, and propagate all labels and
annotations from spec.infrastructure in all generated resources. The
main goal is to conform with below GEP.

Relates: kubernetes-sigs/gateway-api#1757
Signed-off-by: Tam Mach <[email protected]>
This test is not supported in standard channel, hence we need to add to
the exclude list.

Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras force-pushed the pr/tammach/gateway-api-label branch from 50b77da to 074321d Compare August 6, 2024 12:21
@sayboras
Copy link
Member Author

sayboras commented Aug 6, 2024

/ci-gateway-api

@sayboras
Copy link
Member Author

sayboras commented Aug 6, 2024

/ci-integration

@sayboras sayboras marked this pull request as ready for review August 6, 2024 12:48
@sayboras
Copy link
Member Author

sayboras commented Aug 6, 2024

/test

@sayboras sayboras enabled auto-merge August 6, 2024 13:33
@sayboras sayboras added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit cff3456 Aug 6, 2024
281 of 284 checks passed
@sayboras sayboras deleted the pr/tammach/gateway-api-label branch August 6, 2024 14:48
@sayboras sayboras mentioned this pull request Aug 7, 2024
2 tasks
@sayboras sayboras added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Aug 7, 2024
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. and removed backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. feature/k8s-gateway-api release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants