release image: Allow arbitrary pre-release identifiers #33718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
backport/1.16
|
backporting #29173 to v1.16 branch so that this change gets forward ported when we create new stable branches. |
|
/test-backport-1.16 |
Is this accurate? GitHub reports that the linked commit is already in v1.16 EDIT: Oh well yeah probably that commit is in the branch but we broke this when branching off, because we were copying directly from the v1.15 versions of the workflows cc @aanm . If we apply this patch as-is then the existing process should make sure we don't reintroduce this issue during the next v1.17 cycle. |
joestringer
approved these changes
Jul 10, 2024
michi-covalent
force-pushed
the
pr/michi/release-tag
branch
from
389fab9 to
f03427a
Compare
Make the filter patterns for release image tags more lenient to allow arbitrary pre-release identifiers beyond rc. We made a similar change in main branch [^1], but the change got lost when we branched v1.16. Fixes: f5bdf28 ("Prepare v1.16 stable branch") [^1]: #29173 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/release-tag
branch
from
f03427a to
b3619f7
Compare
updated the commit message 🚀 |
|
/test-backport-1.16 |
joestringer
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the filter patterns for release image tags more lenient to allow arbitrary pre-release identifiers beyond rc. We made a similar change in main branch 1, but the change got lost when we branched v1.16.
Fixes: f5bdf28 ("Prepare v1.16 stable branch")
Footnotes
https://github.com/cilium/cilium/pull/29173 ↩