Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: remove unused method NewStandaloneClientset #33055

Conversation

mhofstetter
Copy link
Member

This commit removes the deprecated and now unused method NewStandaloneClientset.

In the meantime, all usages have been moved to use the Hive Cell dependency directly.

@mhofstetter mhofstetter added kind/cleanup This includes no functional changes. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/misc This PR makes changes that have no direct user impact. labels Jun 11, 2024
This commit removes the deprecated and now unused method `NewStandaloneClientset`.

In the meantime, all usages have been moved to use the Hive Cell dependency directly.

Signed-off-by: Marco Hofstetter <[email protected]>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/k8s-remove-NewStandaloneClientset branch from d4dbfd6 to 2796dea Compare June 12, 2024 06:17
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review June 12, 2024 09:33
@mhofstetter mhofstetter requested a review from a team as a code owner June 12, 2024 09:33
@mhofstetter mhofstetter requested a review from youngnick June 12, 2024 09:33
@joamaki joamaki added this pull request to the merge queue Jun 13, 2024
Merged via the queue into cilium:main with commit 74039b5 Jun 13, 2024
63 of 64 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/k8s-remove-NewStandaloneClientset branch June 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants