Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iptables: Remove unneeded cell.Health param #32853

Merged

Conversation

pippolo84
Copy link
Member

The cell.Health reporter is not needed anymore, since one it is already provided to the job registered in the manager by the JobGroup.

@pippolo84 pippolo84 added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Jun 3, 2024
@pippolo84 pippolo84 requested a review from a team as a code owner June 3, 2024 15:35
@pippolo84 pippolo84 requested a review from ysksuzuki June 3, 2024 15:35
@julianwiedmann julianwiedmann added the area/iptables Impacts how Cilium interacts with iptables. label Jun 5, 2024
@julianwiedmann
Copy link
Member

/test

The cell.Health reporter is not needed anymore, since one it is already
provided to the job registered in the manager by the JobGroup.

Signed-off-by: Fabio Falzoi <[email protected]>
@pippolo84 pippolo84 force-pushed the pr/pippolo84/iptables-clean-params branch from c08caa1 to 916f9a7 Compare June 6, 2024 14:06
@pippolo84
Copy link
Member Author

/test

@pippolo84
Copy link
Member Author

ci-integration failure tracked here, rerunning.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 6, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue Jun 6, 2024
Merged via the queue into cilium:main with commit c269031 Jun 6, 2024
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/iptables Impacts how Cilium interacts with iptables. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants